fix(android): fix path error on Windows module builds #14171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a change in the gradle update #14014 and it breaks windows module builds.
It will generate
C:\ ProgramData Titanium mobilesdk win32 12.6.1.GA android templates module generated\TiModuleBootstrap.cpp'as an output path which breaks the build.This change will generate the proper path again by reverting back to the initial replace string (OSX and Linux are using
/so it was never an issue there).It would also be great to merge #14078 . While it might not be the best solution it will enable the windows module builds again. More details in #14077 (comment) (there is no log anyways for all platforms, so even if we fix the bigger part it won't log more then ti info).